[PATCH] D66613: [support][llvm-objcopy] Add support for shell wildcards

Fri Aug 23 09:28:11 PDT 2019

nickdesaulniers added a comment.

In D66613#1642461 <https://reviews.llvm.org/D66613#1642461>, @jhenderson wrote:

> > ! In D66613#1642709 <https://reviews.llvm.org/D66613#1642709>, @MaskRay wrote:
> > 
> >> Also a question, for others as well: is this a feature we actually want to carry forward? Are there any users of this feature/is it useful? This isn't something I've come across as actually being used, though I'm happy to review it if is.
>
> I have the same question.

Android/ChromeOS/Google is looking into using llvm substitutes for binutils for their Linux kernels.  This feature is needed for us to substitute GNU strip for llvm-strip and GNU objcopy for llvm-objcopy.  The upstream Linux kernel has removed the use of these for architectures we ship, but the Long Term Support (LTS) kernels that we will be shipping for the foreseeable future still do.  Backporting the removal of these flags in a way that doesn't also backport features (which is against LTS policy) is likely to be tricky, as it would also cause the LTS branches to start to diverge, making future backports to those source files less likely to apply cleanly.  I'm not confident we could get those patches accepted upstream.  We could always carry them out of tree in Android/ChromeOS/Google, but I'd rather not.

All that not supporting this feature does is delay the use of llvm-objcopy/llvm-strip in a few major Linux distributions for their kernels for a few years.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66613/new/

https://reviews.llvm.org/D66613