[llvm] r369772 - [Reassoc] Small fix to support unary FNeg in NegateValue(...)

[Cameron McInally via llvm-commits]

Author: mcinally
Date: Fri Aug 23 08:49:38 2019
New Revision: 369772

URL: http://llvm.org/viewvc/llvm-project?rev=369772&view=rev
Log:
[Reassoc] Small fix to support unary FNeg in NegateValue(...)

Differential Revision: https://reviews.llvm.org/D66612

Added:
    llvm/trunk/test/Transforms/Reassociate/2019-08-22-FNegAssert.ll
Modified:
    llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp?rev=369772&r1=369771&r2=369772&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp Fri Aug 23 08:49:38 2019
@@ -861,7 +861,7 @@ static Value *NegateValue(Value *V, Inst
     // this use.  We do this by moving it to the entry block (if it is a
     // non-instruction value) or right after the definition.  These negates will
     // be zapped by reassociate later, so we don't need much finesse here.
-    BinaryOperator *TheNeg = cast<BinaryOperator>(U);
+    Instruction *TheNeg = cast<Instruction>(U);
 
     // Verify that the negate is in this function, V might be a constant expr.
     if (TheNeg->getParent()->getParent() != BI->getParent()->getParent())

Added: llvm/trunk/test/Transforms/Reassociate/2019-08-22-FNegAssert.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Reassociate/2019-08-22-FNegAssert.ll?rev=369772&view=auto
==============================================================================
--- llvm/trunk/test/Transforms/Reassociate/2019-08-22-FNegAssert.ll (added)
+++ llvm/trunk/test/Transforms/Reassociate/2019-08-22-FNegAssert.ll Fri Aug 23 08:49:38 2019
@@ -0,0 +1,24 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -reassociate -S | FileCheck %s
+; D61675
+
+define float @test1(float %arg, float %arg1, float %arg2, float %arg3) {
+; CHECK-LABEL: @test1(
+; CHECK-NEXT:    [[TMP5:%.*]] = fneg fast float [[ARG:%.*]]
+; CHECK-NEXT:    [[TMP1:%.*]] = fsub fast float [[ARG3:%.*]], [[ARG2:%.*]]
+; CHECK-NEXT:    [[TMP2_NEG:%.*]] = fadd fast float [[TMP5]], 5.000000e+02
+; CHECK-NEXT:    [[TMP3:%.*]] = fadd fast float [[TMP2_NEG]], [[TMP1]]
+; CHECK-NEXT:    [[TMP4:%.*]] = fmul fast float [[TMP3]], [[TMP3]]
+; CHECK-NEXT:    [[TMP6:%.*]] = fdiv fast float [[TMP5]], [[ARG1:%.*]]
+; CHECK-NEXT:    [[TMP7:%.*]] = fadd fast float [[TMP4]], [[TMP6]]
+; CHECK-NEXT:    ret float [[TMP7]]
+;
+  %tmp1 = fsub fast float %arg3, %arg2
+  %tmp2 = fadd fast float %arg, -5.000000e+02
+  %tmp3 = fsub fast float %tmp1, %tmp2
+  %tmp4 = fmul fast float %tmp3, %tmp3
+  %tmp5 = fneg fast float %arg
+  %tmp6 = fdiv fast float %tmp5, %arg1
+  %tmp7 = fadd fast float %tmp6, %tmp4
+  ret float %tmp7
+}