[PATCH] D66643: [DWARF] Support DWARF64 in DWARFListTableHeader.

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFListTable.cpp:30
+  HeaderData.Length = Data.getRelocatedValue(4, OffsetPtr);
+  if (HeaderData.Length == dwarf::DW_LENGTH_DWARF64) {
+    Format = dwarf::DwarfFormat::DWARF64;
----------------
aprantl wrote:
> Should there be an error if the header is neither known size?
I agree, if the first 4 bytes hold a value that's reserved by DWARF then we should return an error.



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66643/new/

https://reviews.llvm.org/D66643