[PATCH] D66651: Annotate return values of allocation functions with dereferenceable_or_null

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 23 08:28:44 PDT 2019


jdoerfert added a comment.

It seems inconsistent to declare `Op0C` initially and `Op1C` late given that both are need 2 times in almost the same fashion.

We also need tests.

I think this is the right thing to do though, dereferenceability will be used for LICM and AA (D66157 <https://reviews.llvm.org/D66157>), and nonnull can be eliminated with any access or null check (D65402 <https://reviews.llvm.org/D65402> and following).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66651/new/

https://reviews.llvm.org/D66651





More information about the llvm-commits mailing list