[PATCH] D63713: Add error handling to the DataExtractor class

[Pavel Labath via Phabricator via llvm-commits]

labath updated this revision to Diff 216839.
labath marked 12 inline comments as done.
labath added a comment.

- Add doxygen comments. I've tried to be more brief than the existing comments, as I have found them exessively verbose and repetitive (they're longer than the implementation!).
- Fix the double destruction in the death tests
- Remove the template argument from the vector version of the getU8 method -- there's a lot of confusion about whether bytes should be stored as chars or uint8_ts and this was an attempt to placate both. I now think this is not a good idea, and I will try to make the users consistent instead.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63713/new/

https://reviews.llvm.org/D63713

Files:
  include/llvm/DebugInfo/DWARF/DWARFDataExtractor.h
  include/llvm/Support/DataExtractor.h
  lib/DebugInfo/DWARF/DWARFDataExtractor.cpp
  lib/Support/DataExtractor.cpp
  unittests/Support/DataExtractorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63713.216839.patch
Type: text/x-patch
Size: 25188 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190823/6028fbc7/attachment.bin>