[PATCH] D66431: [PDB] Fix bug when using multiple PCH header objects with the same name.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 23 05:29:07 PDT 2019


thakis added a comment.

Is this only for cl.exe-created pch files? Those create special obj files iirc. Or does it affect clang-cl-built pch obj files as well? (If it's cl.exe-only, please mention that in the patch description.)



================
Comment at: lld/test/COFF/precomp-link-samename.test:5
+
+RUN: llvm-pdbutil dump -types %t.pdb | FileCheck %s
+
----------------
Could you add a comment that describes how the checked-in Input files were created?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66431/new/

https://reviews.llvm.org/D66431





More information about the llvm-commits mailing list