[PATCH] D66642: [yaml2obj] - Don't allow setting StOther and Other/Visibility at the same time.

[George Rimar via Phabricator via llvm-commits]

grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.

This is a follow up discussed in the comments of D66583 <https://reviews.llvm.org/D66583>.

Currently, if for example, we have both StOther and Other set in YAML document for a symbol,
then yaml2obj reports an "unknown key 'Other'" error.
It happens because 'mapOptional()' is never called for 'Other/Visibility' in this case,
leaving those unhandled.

This message does not describe the reason of the error well. This patch fixes it.


https://reviews.llvm.org/D66642

Files:
  include/llvm/ObjectYAML/ELFYAML.h
  lib/ObjectYAML/ELFEmitter.cpp
  lib/ObjectYAML/ELFYAML.cpp
  test/tools/yaml2obj/elf-symbol-stother.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66642.216809.patch
Type: text/x-patch
Size: 4967 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190823/fb7f6508/attachment.bin>