[PATCH] D57779: [SLP] Add support for throttling.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added a comment.

In D57779#1642497 <https://reviews.llvm.org/D57779#1642497>, @xbolva00 wrote:

> SPEC results look fine.
>
> Is there anything which blocks this patch? @RKSimon


Some of the results are worse than without the patch. Can we investigate why?



================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:1579
+  /// instructions with partial vectorization.
+  SmallVector<std::unique_ptr<SmallVector<Value *, 8>>, 2> Seeds;
+
----------------
Why do we need to use `unique_ptr` here, why not just `SmallVector`?


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:2921
+  bool Changed = false;
+  for (auto &S1 : Seeds) {
+    SmallVector<Value *, 8> &S = *S1.get();
----------------
`auto`->real type


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57779/new/

https://reviews.llvm.org/D57779