[PATCH] D66141: [FileCheck] Forbid using var defined on same line

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre marked an inline comment as done.
thopre added inline comments.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:114
                            Optional<size_t> DefLineNumber = None,
                            FileCheckExpressionAST *ExpressionAST = nullptr)
+      : Name(Name), DefLineNumber(DefLineNumber) {
----------------
arichardson wrote:
> ExpressionAST is not used anymore?
> Unrelated, but should this constructor be explicit to avoid implicit conversions from StringRef?
Err yes indeed. I really need to get used to that aspect of C++. Will schedule a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66141/new/

https://reviews.llvm.org/D66141