[PATCH] D66608: [InstCombine] icmp eq/ne (gep inbounds P, Idx..), null -> icmp eq/ne P, null

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 23 00:05:16 PDT 2019


jdoerfert added a comment.

In D66608#1642250 <https://reviews.llvm.org/D66608#1642250>, @reames wrote:

> When I went to add the suggested size-0 type bailout, I realized the existing code was correct for this case.  I added tests and a comment to show this.


The comment is helpful, thanks!

I'm good with this but I'm also tired. Let's wait for others to voice their opinion or at least till I can take another look with fresh eyes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66608/new/

https://reviews.llvm.org/D66608





More information about the llvm-commits mailing list