[PATCH] D66461: [CaptureTracker] Comparisons of allocation pointers do not capture

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert planned changes to this revision.
jdoerfert added a comment.

In D66461#1642252 <https://reviews.llvm.org/D66461#1642252>, @hfinkel wrote:

> > As I described, the compare will capture only if the other pointer was captured.
>
> But the other pointer can be captured afterward, no?


Yes, but the idea was that because it is captured we would not rule the `icmp` as "benign".
However, trying to update the patch I realized this is not as simple as the scope in which the other pointer is "not captured" seems important.

I will think about this further and (hopefully) come up with a proposal that might use capture information and the categories I had here as they restrict how a pointer can be "prepared" in the first place.

If anyone has a good idea, let me know, I am almost certain we can do better here and I believe we should as pointer comparisons seem like something that happens frequently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66461/new/

https://reviews.llvm.org/D66461