[PATCH] D66287: GlobalISel: add combiner for indexed loads and stores

[Amara Emerson via Phabricator via llvm-commits]

aemerson added a comment.

On the addition of these opcodes themselves, I don't have a particularly strong opinion. It's unfortunate that we need yet more opcodes but I guess trying to do this analysis during selection might be harder to do because of the partially selected MF, and with the potential code duplication for each target that wants it.

My one concern is with adding the machine dominator analysis the the pipeline at -O0. Is there a significant compile time cost? It's ok if we can pay for it by reducing the amount of code to analyze but we should run the numbers to check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66287/new/

https://reviews.llvm.org/D66287