[PATCH] D66612: [Reassoc] Small fix to support unary FNeg in NegateValue(...)

Michael Berg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 12:43:20 PDT 2019


mcberg2017 added a comment.

LGTM, but I will give Sanjay some time before moving forward.



================
Comment at: llvm/lib/Transforms/Scalar/Reassociate.cpp:916
   // negation.
   BinaryOperator *NewNeg = CreateNeg(V, V->getName() + ".neg", BI, BI);
   ToRedo.insert(NewNeg);
----------------
You will need to revise this one too in D61675 as it will be a unary then.  Just a note to remember.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66612/new/

https://reviews.llvm.org/D66612





More information about the llvm-commits mailing list