[PATCH] D66411: Fix -ftime-trace breaking flame-graph assumptions

Russell Gallop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 12:31:07 PDT 2019


russell.gallop marked 2 inline comments as done.
russell.gallop added inline comments.


================
Comment at: llvm/lib/Support/TimeProfiler.cpp:103
+    auto SortedEntries = SmallVector<Entry, 128>(Entries);
+    llvm::sort(SortedEntries.begin(), SortedEntries.end(),
+               [](const Entry &A, const Entry &B) {
----------------
mgrang wrote:
> You can use the range-based version of llvm:sort here.
> 
> ```
> llvm::sort(SortedEntries);
> ```
Thanks, fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66411/new/

https://reviews.llvm.org/D66411





More information about the llvm-commits mailing list