[PATCH] D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 11:49:14 PDT 2019


jasonliu marked an inline comment as done.
jasonliu added inline comments.


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:186
+  W.printNumber("SectionLength", AuxEntPtr->SectionLength);
+  W.printNumber("NumberOfRelocEnt", AuxEntPtr->NumberOfRelocEnt);
+  W.printNumber("NumberOfLineNum", AuxEntPtr->NumberOfLineNum);
----------------
hubert.reinterpretcast wrote:
> Overflow handling is not here, and there is no TODO.
Discussed offline, the overflow handling is for section auxiliary header, not for symbol auxiliary entry. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65240/new/

https://reviews.llvm.org/D65240





More information about the llvm-commits mailing list