[PATCH] D66180: [GlobalISel][CallLowering] Add support for splitting types according to calling conventions

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 11:15:42 PDT 2019


aemerson marked an inline comment as done.
aemerson added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h:196
+  bool handleAssignments(MachineIRBuilder &MIRBuilder,
+                         SmallVectorImpl<ArgInfo> &Args,
                          ValueHandler &Handler) const;
----------------
t.p.northover wrote:
> It looks like you only use the ability here to change elements, not add/remove them? I think that's a `MutableArrayRef` use-case.
Right, but there's no conversion for SmallVectors to MutableArrayRef, only SmallVectorImpl.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66180/new/

https://reviews.llvm.org/D66180





More information about the llvm-commits mailing list