[PATCH] D66600: Add encode and decode methods to InlineInfo and document encoding format to the GSYM file format

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/DebugInfo/GSYM/InlineInfo.cpp:101
+    clear();
+  }
+}
----------------
This also seems weird. Why wouldn't decode() guarantee that it leaves the object in a consistent state? Why silently swallow the error?

Perhaps it would be cleaner if decode returned an expected<InlineInfo> object? Then you don't need a clear() method in the first place.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66600/new/

https://reviews.llvm.org/D66600