[PATCH] D66600: Add encode and decode methods to InlineInfo and document encoding format to the GSYM file format

[Greg Clayton via Phabricator via llvm-commits]

clayborg marked 2 inline comments as done.
clayborg added inline comments.


================
Comment at: lib/DebugInfo/GSYM/InlineInfo.cpp:63
+
+static bool decodeAll(InlineInfo &Inline, DataExtractor &Data,
+                      uint64_t &Offset, uint64_t BaseAddr) {
----------------
aprantl wrote:
> This returns a bool.. what does that mean?
returns true if a InlineInfo is successfully decoded. This is a static function that is called recursively from within this function. The while statement on line 74 uses the return value.


================
Comment at: lib/DebugInfo/GSYM/InlineInfo.cpp:84
+  uint64_t Offset = 0;
+  decodeAll(*this, Data, Offset, BaseAddr);
+}
----------------
aprantl wrote:
> and here the return value is ignored?
I will clear the InlineInfo if this returns false.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66600/new/

https://reviews.llvm.org/D66600