[PATCH] D66411: Fix -ftime-trace breaking flame-graph assumptions

Russell Gallop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 09:22:28 PDT 2019


russell.gallop updated this revision to Diff 216641.
russell.gallop added a comment.
Herald added a subscriber: mgrang.

Added structure check on time profile and assertion.

Without the fix, this assertion fires compiling a single moderately large source file (~30 seconds). With the fix it compiles fine (even with finer granularity (I tried down to 5 microseconds). I think that this is probably a better check than TimeProfilerTest.cpp so, unless anyone disagrees, I'll remove that and just commit the changes to TimeProfiler.cpp.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66411/new/

https://reviews.llvm.org/D66411

Files:
  llvm/lib/Support/TimeProfiler.cpp
  llvm/unittests/Support/CMakeLists.txt
  llvm/unittests/Support/TimeProfilerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66411.216641.patch
Type: text/x-patch
Size: 9529 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190822/dd4c5e8a/attachment.bin>


More information about the llvm-commits mailing list