[PATCH] D66141: [FileCheck] Forbid using var defined on same line

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

LGTM except for one minor issue.



================
Comment at: llvm/include/llvm/Support/FileCheck.h:114
                            Optional<size_t> DefLineNumber = None,
                            FileCheckExpressionAST *ExpressionAST = nullptr)
+      : Name(Name), DefLineNumber(DefLineNumber) {
----------------
ExpressionAST is not used anymore?
Unrelated, but should this constructor be explicit to avoid implicit conversions from StringRef?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66141/new/

https://reviews.llvm.org/D66141