[PATCH] D66504: [X86][DAGCombiner] Teach narrowShuffle to use concat_vectors instead of inserting into undef

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 08:24:20 PDT 2019


RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:19482
+  auto ConcatWithUndef = [](SDValue Concat) {
+    return std::all_of(std::next(Concat->op_begin()), Concat->op_end(),
+                       [](const SDValue &Op) {
----------------
Not sure if its worth it but you could put the check for getOpcode() == ISD::CONCAT_VECTORS in here as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66504/new/

https://reviews.llvm.org/D66504





More information about the llvm-commits mailing list