[PATCH] D66548: [DAGCombiner] Remove explicit call to AddToWorklist in sqrt and reciprocal computations

Amaury SECHET via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 08:21:04 PDT 2019


deadalnix marked an inline comment as done.
deadalnix added inline comments.


================
Comment at: test/CodeGen/PowerPC/qpx-recipest.ll:205
-; CHECK-DAG: qvfmadds
-; CHECK-DAG: qvfcmpeq
 ; CHECK-DAG: qvfmadds
----------------
jsji wrote:
> lebedev.ri wrote:
> > deadalnix wrote:
> > > RKSimon wrote:
> > > > deadalnix wrote:
> > > > > RKSimon wrote:
> > > > > > Is the qvfcmpeq removed as well?
> > > > > Let me double check, it may be an error of mine.
> > > > How bad would it be to use the update script and regenerate all the CHECKs?
> > > As far as I know, this is not available for PowerPC, unless something changed recently.
> > Shouldn't be too complicated to add
> I just tried, it should work.
As it turns out, I'm incorrect, so I'll do this and update the diff accordingly before landing.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66548/new/

https://reviews.llvm.org/D66548





More information about the llvm-commits mailing list