[PATCH] D66574: [lit] Make internal diff work in pipelines

[Paul Robinson via Phabricator via llvm-commits]

probinson added a subscriber: MaggieYi.
probinson added a comment.

+Maggie who did the original diff implementation, AFAICT.

As before, someone with actual Python chops should review this.  I've made some functionality remarks.



================
Comment at: llvm/utils/lit/lit/builtin_commands/diff.py:196
+    try:
+        opts, args = getopt.gnu_getopt(args, "wbur", ["strip-trailing-cr"])
+    except getopt.GetoptError as err:
----------------
I've also seen "a" and "U1" in my searches.
Does this correctly handle combined short options? e.g. "-aub" which I see used a fair amount.
I didn't notice `--strip-trailing-cr` anywhere but presumably the original author needed it, so probably should keep it.
I was going to say we don't need to bother with "r" but then I found a case that used it!


================
Comment at: llvm/utils/lit/tests/shtest-shell.py:7
 # RUN: cat %t.out
-# RUN: FileCheck --input-file %t.out %s
+# RUN: FileCheck -dump-input=fail -vv -color --input-file %t.out %s
 #
----------------
Is this for your temporary benefit or did you intend to make this change permanent? "-color" in particular seems odd here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66574/new/

https://reviews.llvm.org/D66574