[PATCH] D66050: Improve division estimation of floating points.
Hal Finkel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 22 06:01:42 PDT 2019
hfinkel added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:20080
+ // Newton iterations: Est = Est + Est (N - Arg * Est)
+ // If this is the last time of iteration, try taking numerator into
+ // consideration.
----------------
"last time of iteration" -> "last iteration"
"try taking numerator into consideration" -> "also multiply by the numerator"
================
Comment at: llvm/test/CodeGen/PowerPC/combine-fneg.ll:19
+; CHECK-NEXT: xxswapd 4, 4
; CHECK-NEXT: xvnmsubadp 1, 2, 0
+; CHECK-NEXT: xxlor 3, 2, 2
----------------
xbolva00 wrote:
> Regression
There's still an extra arithmetic instruction here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66050/new/
https://reviews.llvm.org/D66050
More information about the llvm-commits
mailing list