[PATCH] D66532: [yaml2obj] - Lookup relocation symbols in dynamic symbol when .dynsym referenced.

[George Rimar via Phabricator via llvm-commits]

grimar marked 5 inline comments as done.
grimar added inline comments.


================
Comment at: test/tools/yaml2obj/dynamic-relocations.yaml:62
+      Binding: STB_GLOBAL
+    - Name: both
+      Section: .data
----------------
jhenderson wrote:
> Minor point, but it might make sense to have `both` first in one of the two tables so that it doesn't have the same index. If I'm not mistaken, in the currents situation, the unpatched yaml2obj would actually generate the right thing as things stand for `both`.
Good point, I did that, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66532/new/

https://reviews.llvm.org/D66532