[PATCH] D64281: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 1]

Alex Brachet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 18:30:21 PDT 2019


abrachet added a comment.

I've been thinking about this, is `size_t` safe to use? Some methods from inherited classes use `uint64_t` on my machine its fine because even `unsigned long` and `unsigned long long` have the same width and sign but on a 32 bit machine I think that assigning to a `size_t` (which is guaranteed to be word size, I think) from a `uint64_t` might produce a warning. I don't think there are any examples in this patch, but this seemed like the best place to ask.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64281/new/

https://reviews.llvm.org/D64281





More information about the llvm-commits mailing list