[PATCH] D66449: [llvm-objcopy] Accept MachO formats in commad-line parsing

Wed Aug 21 13:22:32 PDT 2019

rupprecht added inline comments.

================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:271
+    {"sparcel", {ELF::EM_SPARC, 0, 0, false, true}},
+    {"x86-64",
+     {ELF::EM_X86_64, MachO::CPU_TYPE_X86_64, MachO::CPU_SUBTYPE_X86_64_ALL,
----------------
It looks like GNU objcopy doesn't even accept `-B x86-64`, I wonder if we should consider dropping it. The arch used for that case is actually `i386:x86-64`.

================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:272
+    {"x86-64",
+     {ELF::EM_X86_64, MachO::CPU_TYPE_X86_64, MachO::CPU_SUBTYPE_X86_64_ALL,
+      true, true}},
----------------
jhenderson wrote:
> Does Mach-O not support the other CPU types?
It seems it accepts ~any CPU type (`-I binary -B alpha -O mach-o-x86-64` works), though the effects don't seem to be visible (the CpuType/CpuSubType are always X86-64/CPU_SUBTYPE_X86_64_ALL regardless of the `-B` option).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66449/new/

https://reviews.llvm.org/D66449