[PATCH] D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/trunk/include/llvm/Support/Compiler.h:255
 #define LLVM_FALLTHROUGH [[fallthrough]]
 #elif __has_cpp_attribute(gnu::fallthrough)
 #define LLVM_FALLTHROUGH [[gnu::fallthrough]]
----------------
then this should have a guard for `__cplusplus`, too then? (or an `#if` around the C++ parts).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66487/new/

https://reviews.llvm.org/D66487