[PATCH] D66539: [ELF][ARM] Simplify some llvm-objdump tests with both ARM/Thumb states
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 21 12:16:14 PDT 2019
efriedma added a comment.
> (a) have two MCInstrAnalysis (how), (b) pass an extra parameter to evaluateBranch, or (c) make it stateful?
We could also check whether the opcode is an ARM opcode or a Thumb opcode... they don't overlap at all for the relevant opcodes. But passing in the MCSubtargetInfo to evaluateBranch seems like a really easy change.
Not sure how making it "stateful" helps here.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66539/new/
https://reviews.llvm.org/D66539
More information about the llvm-commits
mailing list