[PATCH] D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 11:58:25 PDT 2019


nickdesaulniers added inline comments.


================
Comment at: llvm/trunk/include/llvm/Support/Compiler.h:19
 
+#ifdef __cplusplus
 #include <new>
----------------
The original code used `#if __cplusplus` (notice `#if`, not `#ifdef`).  I'm surprised that worked.  Maybe this change needs to as well?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66487/new/

https://reviews.llvm.org/D66487





More information about the llvm-commits mailing list