[PATCH] D66545: [WebAssembly] Add Emscripten support for UBSan, LSan and ASan

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: compiler-rt/lib/lsan/lsan_common.cpp:173
+    // when scanning globals instead of when scanning thread-locals.
+#if SANITIZER_EMSCRIPTEN && !defined(USE_THREADS)
+  uptr cache_begin, cache_end;
----------------
Why not combine this block with the block below that looks like the only user of cache_begin, cache_end?

Also the comment looks incorrectly indented.   


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_flag_parser.cpp:21
+#if SANITIZER_EMSCRIPTEN
+extern "C" void emscripten_builtin_free(void *);
+#include <emscripten/em_asm.h>
----------------
Perhaps worth putting these `emscripten_builtin_` functions in the header file and then `#include <emscripten/foo.h>` here and elsewhere rather than forward declaring them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66545/new/

https://reviews.llvm.org/D66545