[PATCH] D65506: [MachineScheduler] improve reuse of 'releaseNode'method

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 10:33:52 PDT 2019


fhahn added a comment.

In D65506#1634086 <https://reviews.llvm.org/D65506#1634086>, @DoktorC wrote:

> Further, fix update of `MinReadyCycle`: it was set to `SU->ReadyCycle`, even if the
>  scheduling unit was not moved to the `Available` queue.
>  (thank @fhahn)


This change causes a crash, because MinReadyCycle is not properly initialised when going through `pickOnlyChoice`. I think we should address that separately and I'll commit the version with setting MinReadyCycle at the original position.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65506/new/

https://reviews.llvm.org/D65506





More information about the llvm-commits mailing list