[PATCH] D66533: [MIPS GlobalISel] ClampScalar G_SHL, G_ASHR and G_LSHR
Petar Avramovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 21 09:02:07 PDT 2019
Petar.Avramovic marked an inline comment as done.
Petar.Avramovic added inline comments.
================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:3001
auto LoL = MIRBuilder.buildConstant(HalfTy, 0); // Lo part is zero.
- auto HiL = MIRBuilder.buildShl(HalfTy, InL, AmtExcess); // Hi from Lo part.
+ auto HiL = MIRBuilder.buildShl(HalfTy, InL, Amt); // Hi from Lo part.
----------------
arsenm wrote:
> This now differs from the DAG version?
Oh, now I see it, didn't look into DAG version, I was guided by the test.
Will have to double check this.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66533/new/
https://reviews.llvm.org/D66533
More information about the llvm-commits
mailing list