[PATCH] D66532: [yaml2obj] - Lookup relocation symbols in dynamic symbol when .dynsym referenced.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 21 06:55:39 PDT 2019
grimar marked an inline comment as done.
grimar added inline comments.
================
Comment at: lib/ObjectYAML/ELFEmitter.cpp:1001
WithColor::error() << "Local symbol '" + Name +
"' after global in Symbols list.\n";
return false;
----------------
btw, since this code is now used for dynamic symbols and yaml2obj is
generally a tool that makes possible to produce the broken binaries,
perhaps I'd try to remove this restriction logic for both regular and dynamic symbols
in a follow up.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66532/new/
https://reviews.llvm.org/D66532
More information about the llvm-commits
mailing list