[PATCH] D66426: [lld] Enable a watermark of loadable sections to be generated and placed in a note section

Dave Bozier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 06:46:42 PDT 2019


davidb added a comment.

Thanks for the detailed explanation, mostly tally's up with what I've just read. One thing

In D66426#1639109 <https://reviews.llvm.org/D66426#1639109>, @MaskRay wrote:

> Non-SHF_ALLOC SHT_NOTE section exist in the wild, but they are rare


I don't think this case should be considered rare (I actually thought the opposite case was rare...). The ELF spec describes SHT_NOTE section to not have any defining attributes (SHF_ALLOC), and most embedded/memory critical systems won't want notes in memory, so I think this is very much target dependent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66426/new/

https://reviews.llvm.org/D66426





More information about the llvm-commits mailing list