[PATCH] D66413: [ARM} Add support for MVE vmaxv

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:1064
     return false;
+  case Instruction::ICmp:
   case Instruction::Add:
----------------
Is there a VMINV patch too? Am I correct that this would enable both min and max reduction intrinsics?


================
Comment at: llvm/test/CodeGen/Thumb2/mve-vmaxv.ll:14
+; CHECK-NEXT:    mov.w r0, #-128
+; CHECK-NEXT:    vmaxv.s8 r0, q0
+; CHECK-NEXT:    bx lr
----------------
The old code for these was quite large, right? Much larger than needing to materialise the constant?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66413/new/

https://reviews.llvm.org/D66413