[PATCH] D66426: [lld] Enable a watermark of loadable sections to be generated and placed in a note section

[Dave Bozier via Phabricator via llvm-commits]

davidb added a comment.

In D66426#1639065 <https://reviews.llvm.org/D66426#1639065>, @davidb wrote:

> In D66426#1637540 <https://reviews.llvm.org/D66426#1637540>, @MaskRay wrote:
>
> > Another problem is that .note.gnu.build-id is SHF_ALLOC and included in a PT_LOAD segment. When computing watermark, you probably don't want to include its contents. So you should compute build-id and watermark first before you write.
>
>
> What target are you looking at? I thought generally note sections aren't allocated and are usually safe to remove. If they were included in a segment, then that would be a PT_NOTE segment that isn't nested in a PT_LOAD segment.


Actually nevermind. I've just found a few example of scripts placing the build-id into text so the value can be accessed at runtime.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66426/new/

https://reviews.llvm.org/D66426