[PATCH] D66339: [SVE] Fixed-length vector MVT ranges

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

In D66339#1633368 <https://reviews.llvm.org/D66339#1633368>, @greened wrote:

> In D66339#1632975 <https://reviews.llvm.org/D66339#1632975>, @sdesmalen wrote:
>
> > I like your suggestion of using `concat_iterator(_range)`, but I think grouping all fixed-width types together is sufficient for now. If there is ever a good reason to iterate through `(all combined scalable and fixed-width fp vector types)`or `(all combined scalable and fixed-width integer vector types)`, we can always introduce the extra `concat_iterators` then.
>
>
> I'm not sure what you're suggesting here.  Are you asking Graham to keep all the fixed-width types contiguous (i.e. int and fp)?  This patch does not do that.  I don't have a strong preference either way.  Given that the existing state is non-contiguous I see no compelling reason to change it.


I was suggesting to change the order of the MVTs to keep all the fixed-width types contiguous (int and fp), as a lighter weight alternative to introducing the filter/concat iterators, since this would probably suffice for most use-cases. We can always introduce the concat iterators later if needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66339/new/

https://reviews.llvm.org/D66339