[PATCH] D66418: [llvm-objdump] - Cleanup the error reporting.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 02:41:30 PDT 2019


grimar marked an inline comment as done.
grimar added a comment.





================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:425
+
+static void reportCmdLineError(Twine Message) {
+  WithColor::error(errs(), ToolName) << Message << "\n";
----------------
jhenderson wrote:
> `LLVM_ATTRIBUTE_NORETURN`?
Seems - yes. Is anything else needed to be fixed or will you be OK if I land this patch with this fix?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66418/new/

https://reviews.llvm.org/D66418





More information about the llvm-commits mailing list