[PATCH] D66517: [llvm-objdump] - Remove one of the `reportError` functions.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 02:00:58 PDT 2019


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: seiya, rupprecht.

There is a problem with `reportError` we have. Declaration says we have `ArchiveName`
that follows the `FileName`:

  reportError(Error E, StringRef FileName, StringRef ArchiveName,...

Though implementation have them reversed. I cleaned it up and
removed an excessive `reportError(Error E, StringRef File)` version.

Rebased on top of D66418 <https://reviews.llvm.org/D66418>.


https://reviews.llvm.org/D66517

Files:
  tools/llvm-objdump/MachODump.cpp
  tools/llvm-objdump/llvm-objdump.cpp
  tools/llvm-objdump/llvm-objdump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66517.216346.patch
Type: text/x-patch
Size: 9932 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190821/d8fded0f/attachment.bin>


More information about the llvm-commits mailing list