[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

Compilation fails with this patch
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/22936/steps/bootstrap%20clang/logs/stdio

  [  8%] Built target LLVMMC
  /b/sanitizer-x86_64-linux/build/llvm/lib/Support/regcomp.c:541:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
          default:
          ^
  /b/sanitizer-x86_64-linux/build/llvm/lib/Support/regcomp.c:541:2: note: insert '__attribute__((fallthrough));' to silence this warning
          default:
          ^
          __attribute__((fallthrough)); 
  /b/sanitizer-x86_64-linux/build/llvm/lib/Support/regcomp.c:541:2: note: insert 'break;' to avoid fall-through
          default:
          ^
          break; 
  /b/sanitizer-x86_64-linux/build/llvm/lib/Support/regcomp.c:737:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
          default:
          ^
  /b/sanitizer-x86_64-linux/build/llvm/lib/Support/regcomp.c:737:2: note: insert '__attribute__((fallthrough));' to silence this warning
          default:
          ^
          __attribute__((fallthrough)); 
  /b/sanitizer-x86_64-linux/build/llvm/lib/Support/regcomp.c:737:2: note: insert 'break;' to avoid fall-through
          default:
          ^
          break; 
  /b/sanitizer-x86_64-linux/build/llvm/lib/Support/regcomp.c:1639:3: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
                  default:                /* things that break a sequence */
                  ^
  /b/sanitizer-x86_64-linux/build/llvm/lib/Support/regcomp.c:1639:3: note: insert '__attribute__((fallthrough));' to silence this warning
                  default:                /* things that break a sequence */
                  ^
                  __attribute__((fallthrough)); 
  /b/sanitizer-x86_64-linux/build/llvm/lib/Support/regcomp.c:1639:3: note: insert 'break;' to avoid fall-through
                  default:                /* things that break a sequence */
                  ^
                  break; 
  3 errors generated.
  lib/Support/CMakeFiles/LLVMSupport.dir/build.make:2558: recipe for target 'lib/Support/CMakeFiles/LLVMSupport.dir/regcomp.c.o' failed
  make[3]: *** [lib/Support/CMakeFiles/LLVMSupport.dir/regcomp.c.o] Error 1
  CMakeFiles/Makefile2:1206: recipe for target 'lib/Support/CMakeFiles/LLVMSupport.dir/all' failed
  make[2]: *** [lib/Support/CMakeFiles/LLVMSupport.dir/all] Error 2
  CMakeFiles/Makefile2:22547: recipe for target 'tools/gold/CMakeFiles/LLVMgold.dir/rule' failed
  make[1]: *** [tools/gold/CMakeFiles/LLVMgold.dir/rule] Error 2
  Makefile:6905: recipe for target 'LLVMgold' failed
  make: *** [LLVMgold] Error 2
  + echo @@@STEP_FAILURE@@@
  + check_64bit 1 sanitizer
  + CONDITION=1
  + SANITIZER=sanitizer
  @@@STEP_FAILURE@@@
  + '[' 1 == 1 ']'
  + echo @@@BUILD_STEP 64-bit check-sanitizer@@@
  
  
  --------------------------------------------------------------------------------
  started: Wed Aug 21 01:01:43 2019
  ended: Wed Aug 21 01:17:17 2019
  duration: 15 mins, 34 secs


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64838/new/

https://reviews.llvm.org/D64838