[PATCH] D65242: [ELF] More dynamic relocation packing

Wed Aug 21 00:08:21 PDT 2019

grimar added a comment.

In D65242#1638787 <https://reviews.llvm.org/D65242#1638787>, @MaskRay wrote:

> Weird. http://lab.llvm.org:8011/builders/lld-x86_64-freebsd/builds/34407/steps/test_lld/logs/stdio (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-ubsan/builds/14511/steps/check-lld%20ubsan/logs/stdio has a similar error message)
>
>   /usr/home/buildslave/as-bldslv5/lld-x86_64-freebsd/llvm.src/tools/lld/test/ELF/pack-dyn-relocs.s:106:20: error: ANDROID32-NEXT: is not on the line after the previous match
>   // ANDROID32-NEXT: 0x2044 R_ARM_ABS32 bar2 0x0
>                      ^
>   <stdin>:36:2: note: 'next' match was here
>    0x2044 R_ARM_ABS32 bar2 0x0
>    ^
>   <stdin>:34:29: note: previous match ended here
>    0x2020 R_ARM_ABS32 bar2 0x0
>                               ^
>   <stdin>:35:1: note: non-matching line after previous match is here
>    0x2040 R_ARM_ABS32 zed2 0x0
>

I wonder if `llvm::sort` instead of stable sort can be the reason?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65242/new/

https://reviews.llvm.org/D65242