[PATCH] D66472: [DWARF] Adjust return type of DWARFUnit::getLength().

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 23:26:20 PDT 2019


ikudrin added a comment.

For the record, there are only a few places where `DWARFUnit::getLength()` is used:

- `DWARFCompileUnit::dump()` -- fixed
- `DWARFTypeUnit::dump()` -- fixed
- `dumpDebugInfo()` in `tools/obj2yaml/dwarf2yaml.cpp` -- already accepts `uint64_t`; looks like already supports DWARF64 but worth reviewing.
- `readCuList()` in `lld/ELF/SyntheticSections.cpp` -- already accepts `uint64_t`; probably supports only DWARF32 for now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66472/new/

https://reviews.llvm.org/D66472





More information about the llvm-commits mailing list