[PATCH] D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: compiler-rt/lib/gwp_asan/CMakeLists.txt:115-116
+        stack_trace_compressor_fuzzer PROPERTIES LINK_FLAGS -fsanitize=fuzzer)
+    add_dependencies(fuzzer stack_trace_compressor_fuzzer)
+    add_dependencies(gwp_asan stack_trace_compressor_fuzzer)
+  endif()
----------------
hctim wrote:
> pcc wrote:
> > Shouldn't the order of these be reversed, i.e.
> > ```
> > add_dependencies(stack_trace_compressor_fuzzer gwp_asan fuzzer)
> > ```
> > https://cmake.org/cmake/help/latest/command/add_dependencies.html
> > 
> > I think that means that you don't need to move the target ordering around.
> > 
> Thanks for the catch - looks like this resolves the issue. Slight change is that the desire is for the fuzzer to be built with `ninja gwp_asan`, so the `add_dependencies(gwp_asan stack_trace_compressor_fuzzer)` is WAI :)
That dependency edge seems mildly surprising to me, but it's your project.

That aside though, how is this linking successfully without a dependency from the fuzzer to `gwp_asan`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66494/new/

https://reviews.llvm.org/D66494