[PATCH] D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer.
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 20 17:43:13 PDT 2019
pcc added inline comments.
================
Comment at: compiler-rt/lib/gwp_asan/CMakeLists.txt:115-116
+ stack_trace_compressor_fuzzer PROPERTIES LINK_FLAGS -fsanitize=fuzzer)
+ add_dependencies(fuzzer stack_trace_compressor_fuzzer)
+ add_dependencies(gwp_asan stack_trace_compressor_fuzzer)
+ endif()
----------------
Shouldn't the order of these be reversed, i.e.
```
add_dependencies(stack_trace_compressor_fuzzer gwp_asan fuzzer)
```
https://cmake.org/cmake/help/latest/command/add_dependencies.html
I think that means that you don't need to move the target ordering around.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66494/new/
https://reviews.llvm.org/D66494
More information about the llvm-commits
mailing list