[PATCH] D66506: [lit][NFC] Capture boilerplate for in-process shell builtins

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 16:56:29 PDT 2019


jdenny added a comment.

In D66506#1638493 <https://reviews.llvm.org/D66506#1638493>, @rnk wrote:

> lgtm
>
> I suppose you could add a test for composing `env` with in process builtins, but I think that's already in the next patch.


Good point.  I originally wrote this patch after the next one, and I forgot about that change when I reversed them.  That also means this patch isn't NFC.

I'll clean that up before pushing.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66506/new/

https://reviews.llvm.org/D66506





More information about the llvm-commits mailing list