[PATCH] D65697: [lit] Fix internal env calling internal commands

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

Now this one is super simple. :)



================
Comment at: llvm/utils/lit/lit/TestRunner.py:852-853
+            #   env FOO=1 %{another_env_plus_cmd} | FileCheck %s
+            if cmd_shenv is shenv:
+                cmd_shenv = ShellEnvironment(shenv.cwd, shenv.env)
+            args = updateEnv(cmd_shenv, args)
----------------
I guess this is a nit, but I'd pull the copy out of the loop and guard it with a single `if args[0] == 'env':` check. That way it's clearer that it only happens once.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65697/new/

https://reviews.llvm.org/D65697