[PATCH] D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c
Aaron Ballman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 20 15:37:46 PDT 2019
aaron.ballman accepted this revision.
aaron.ballman added inline comments.
================
Comment at: llvm/include/llvm/Support/Compiler.h:530
+#if __cplusplus
namespace llvm {
----------------
nickdesaulniers wrote:
> aaron.ballman wrote:
> > `#if defined(__cplusplus)` here as well.
> is `#ifdef __cplusplus` against a style guide? Usually I only use `defined` if there's more than one symbol to check.
I don't think we care either way; I certainly don't have a preference here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66487/new/
https://reviews.llvm.org/D66487
More information about the llvm-commits
mailing list