[PATCH] D61787: [GlobalISel Legalizer] Improve artifact combiner

Volkan Keles via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 15:28:36 PDT 2019


volkan added a comment.

Hi Petar,

Sorry for the slow reply.

I think it’s okay not to combine legal artifacts because 1) targets don’t control over it, and 2) we don’t know if the result of the combine is ideal. Therefore, I don’t think adding more combines would improve the legalizer. We should probably work on the current legalization strategy first before doing something like that. What do you think?

In the mean time, I would like to commit D65894 <https://reviews.llvm.org/D65894> if you don’t have any concerns about it. It will allow us to legalize the instructions blocked by illegal artifacts without trying to improve the generated code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61787/new/

https://reviews.llvm.org/D61787





More information about the llvm-commits mailing list