[PATCH] D65633: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 3]
Jordan Rupprecht via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 20 15:24:03 PDT 2019
rupprecht accepted this revision.
rupprecht added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/unittests/Object/MutableELFObjectTest.cpp:506-508
+ EXPECT_EQ(
+ std::distance(MutableObject.section_begin(), MutableObject.section_end()),
+ 5);
----------------
These checks should also use the same pattern above (checking the whole list of section names), with the common bits extracted to a utility method.
(A gmock matcher would be nice, but the API to write a new matcher is insanely hard to get right).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65633/new/
https://reviews.llvm.org/D65633
More information about the llvm-commits
mailing list